Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restyle Spake2p implementation for mbedTLS #1973

Closed
wants to merge 4 commits into from
Closed

Restyle Spake2p implementation for mbedTLS #1973

wants to merge 4 commits into from

Conversation

restyled-io[bot]
Copy link
Contributor

@restyled-io restyled-io bot commented Aug 4, 2020

A duplicate of #1972 with additional commits that automatically address
incorrect style, created by Restyled.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.

The following Restylers made fixes:

  • clang-format

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to
    the original Pull Request

    Expand for example instructions 
    ```console
git remote add upstream https://github.com/project-chip/connectedhomeip.git
git fetch upstream pull/<this PR number>/head
git merge --ff-only FETCH_HEAD
git push
```

NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.

Sorry if this was unexpected. To disable it, see our documentation.

@restyled-io restyled-io bot added the restyled label Aug 4, 2020
@boring-cyborg boring-cyborg bot added the crypto label Aug 4, 2020
@restyled-io restyled-io bot closed this Aug 4, 2020
@restyled-io restyled-io bot deleted the restyled/pull-1972 branch August 4, 2020 20:53
@github-actions
Copy link

github-actions bot commented Aug 4, 2020

Size increase report for "nrf-example-build"

File Section File VM
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-nrf52840-lock-example.out and ./pull_artifact/chip-nrf52840-lock-example.out:

sections,vmsize,filesize
.debug_loc,0,3261
.debug_info,0,3018
.debug_line,0,1058
.debug_frame,0,316
.debug_abbrev,0,109
.debug_str,0,86
.debug_macro,0,76
.debug_aranges,0,48
.debug_ranges,0,24
[Unmapped],0,4

@github-actions
Copy link

github-actions bot commented Aug 4, 2020

Size increase report for "nrfconnect-example-build"

File Section File VM
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-nrf52840-lock-example.elf and ./pull_artifact/chip-nrf52840-lock-example.elf:

sections,vmsize,filesize
.debug_info,0,801
.debug_line,0,665
.debug_abbrev,0,88
.debug_str,0,57
.debug_aranges,0,8
.debug_ranges,0,8
[Unmapped],0,5
.debug_frame,0,-8

@github-actions
Copy link

github-actions bot commented Aug 4, 2020

Size increase report for "linux-example-build"

File Section File VM
chip-standalone-demo.out [LOAD #5 [RW]] 8 8
chip-standalone-demo.out [LOAD #2 [R]] 1 1
chip-standalone-demo.out .gnu.version -2 -2
chip-standalone-demo.out .got -8 -8
chip-standalone-demo.out .dynstr -15 -15
chip-standalone-demo.out .plt -16 -16
chip-standalone-demo.out .plt.sec -16 -16
chip-standalone-demo.out .dynsym -24 -24
chip-standalone-demo.out .rela.plt -24 -24
chip-standalone-demo.out .text -64 -64
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-standalone-demo.out and ./pull_artifact/chip-standalone-demo.out:

sections,vmsize,filesize
[Unmapped],0,155
[LOAD #5 [RW]],8,8
[LOAD #2 [R]],1,1
.gnu.version,-2,-2
.got,-8,-8
.debug_str,0,-14
.dynstr,-15,-15
.plt,-16,-16
.plt.sec,-16,-16
.debug_loc,0,-21
.dynsym,-24,-24
.rela.plt,-24,-24
.symtab,0,-24
.strtab,0,-30
.text,-64,-64
.debug_info,0,-66
.debug_line,0,-96

@github-actions
Copy link

github-actions bot commented Aug 4, 2020

Size increase report for "esp32-example-build"

File Section File VM
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-wifi-echo.elf and ./pull_artifact/chip-wifi-echo.elf:

sections,vmsize,filesize
.debug_line,0,1635
.debug_info,0,803
.debug_abbrev,0,88
.debug_str,0,70
.debug_frame,0,28
.debug_aranges,0,8
.debug_ranges,0,8

@github-actions
Copy link

github-actions bot commented Aug 4, 2020

Size increase report for "gn_nrf-example-build"

File Section File VM
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

@github-actions
Copy link

github-actions bot commented Aug 4, 2020

Size increase report for "gn_linux-example-build"

File Section File VM
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

chirag-silabs pushed a commit to rosahay-silabs/connectedhomeip that referenced this pull request Jul 15, 2024
@Sarthak-Shaha
Pull request project-chip#1973: MATTER-2920:Readme/caracal boards
01d1959 
Merge in WMN_TOOLS/matter from readme/caracal_boards to silabs_slc_1.3

Squashed commit of the following:

commit eaccea339db51f65252c6a934b8ee5772d9fd0df
Author: Sarthak Shaha <[email protected]>
Date:   Wed Jun 19 23:52:36 2024 +0530

    creating directories for copy extension

commit 904429f5fcfdf95b3819df13fb9968ae3f11b569
Author: Sarthak Shaha <[email protected]>
Date:   Wed Jun 19 19:06:43 2024 +0530

    updates copy extension

commit 8327d1ddaaa923f60865842eefefa2129e4d3e1f
Author: Sarthak Shaha <[email protected]>
Date:   Thu Jun 13 20:21:11 2024 +0530

    Made chages in copy-extension to match provision readme paths

    readme update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@BroderickCarlin BroderickCarlin Awaiting requested review from BroderickCarlin

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
crypto restyled
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pan-apple @balducci-apple @restyled-commits